Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12879][Table SQL / Runtime] Improve the performance of AbstractBinaryWriter #8773

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liyafan82
Copy link
Contributor

What is the purpose of the change

Improve the performance of AbstractBinaryWriter by:

  1. remove unnecessary memory copy
  2. improve the performance of rounding buffer size.

Brief change log

(for example:)

  • Improve the performance of roundNumberOfBytesToNearestWord and reduce the branch statement.
  • Remove one memory copy in writeString method

Verifying this change

This change is already covered by existing tests, such as (BaseRowTest, BinaryRowTest).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (yes)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liyafan82 , the reason why copy data to tmp byte[] is that SegmentsUtil.getByte has poor performance. The simple getByte shouldn't be so many codes.
So my judgement is: copy bytes should quicker.

@liyafan82
Copy link
Contributor Author

Thanks @liyafan82 , the reason why copy data to tmp byte[] is that SegmentsUtil.getByte has poor performance. The simple getByte shouldn't be so many codes.
So my judgement is: copy bytes should quicker.

@JingsongLi
Thanks for the clarification.
I should have thought more about it before submitting this PR.

…tBinaryWriter

[FLINK-12879][Table SQL / Runtime] Improve the performance of AbstractBinaryWriter

[FLINK-12879][Table SQL / Runtime] Restore the logic for writing string

Revert "[FLINK-12879][Table SQL / Runtime] Restore the logic for writing string"

This reverts commit 9effbab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants