-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-12710][table] Prepare expressions for a new resolved expression #8790
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for all the changes.
side-comment: I really like 8f097f3 (I was guilty of a big part of this consistency before this change)
Thanks for the review @dawidwys. I added one more minor commit to round up the whole refactoring story. |
public List<Expression> getChildren() { | ||
return this.args; | ||
public String asSummaryString() { | ||
final List<String> argList = args.stream().map(Object::toString).collect(Collectors.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you could do collect(Collectors.joining("(", ", ", ")");
Feel free to ignore though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even better: also call asSummaryString
there. thanks for the hint :)
Merged. |
What is the purpose of the change
This PR is preparation work for FLINK-12710 that will introduce a new expression with resolved data type. This refactors the existing expression structure.
Brief change log
See commit messages.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation