-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13090][hive] Test Hive connector with hive runner #8987
Conversation
cc @xuefuz @bowenli86 @zjuwangg |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c0939e0 (Wed Aug 07 08:14:55 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. PR looks good to me. One thing that I'm not sure of is about the license. Do we need to update the license file as we are introducing some external libraries (though for test only). Please verify.
@zjuwangg Since you're mostly familiar to HiveRunner, please also take a look. Thanks.
@xuefuz I don't think we need to worry about licenses because all the newly introduced deps are in test scope and only intended to be used during testing. |
Sounds good then. +1 for the PR to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I only have time to briefly look at the PR, and most part LGTM. @zjuwangg can you help to review this in detail?
...tor-hive/src/test/java/org/apache/flink/batch/connectors/hive/FlinkStandaloneHiveRunner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent time and took a closer look at this PR. LGTM
Can you rebase to master? @lirui-apache
...e/src/test/java/org/apache/flink/batch/connectors/hive/FlinkStandaloneHiveServerContext.java
Outdated
Show resolved
Hide resolved
Rebased and addressed comments. @bowenli86 please take another look, thanks. |
@lirui-apache LGTM, thanks for your contribution. Merging |
What is the purpose of the change
To use hive runner in our hive connector tests.
Brief change log
FlinkStandaloneHiveRunner
which launches a standalone HMS and provides an embedded Hive shell. The standalone HMS is closer to real world deployment, and the Hive shell makes it easier for us to write test cases.HiveTableSinkTest
to useFlinkStandaloneHiveRunner
, so that we can use the Hive shell to verify data instead of reading from files ourselves. This will give us more confidence that the written data is hive-compatible.Verifying this change
Adapted existing test cases.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation