[FLINK-13110][hive] add shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4

[lirui-apache]

What is the purpose of the change

This PR adds shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4

Brief change log

• Added shim for creating SimpleGenericUDAFParameterInfo, because SimpleGenericUDAFParameterInfo have different constructors in 1.2.1 and 2.3.4.
• Fixed issue when we call StandardStructObjectInspector.getStructFieldData

Verifying this change

Built and tested against Hive-1.2.1 locally.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? NA

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[lirui-apache]

Ping @xuefuz @bowenli86 @zjuwangg for review. Meanwhile I'd suggest we hold on changes to hive connector until the build is fixed.

[xuefuz]

LGTM. Thanks for fixing ths.

Probably from now on, we should run hive 1.2.1 profile whenever we introduce a call to a new HIve method before CI covers this part of test.

[zentol]

CI report for commit 82d4064: FAILURE Travis

[bowenli86]

LGTM, @lirui-apache thanks for fixing the problem! I agree that we should be careful and should test hive-1.2.1 profile for every change since now locally before CI runs for hive-1.2.1.

Just a side note that we can probably rename the JIRA and PR to something like "add shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4" to be more clear on what it's about.

@zentol I looked at the build failures in detail. Please correct me if I'm wrong - I believe they are not related, as this PR only affects flink-connector-hive module.

[lirui-apache]

Thanks @xuefuz and @bowenli86 for the review. I just rebased the PR.

Just a side note that we can probably rename the JIRA and PR to something like "add shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4" to be more clear on what it's about.

This PR isn't just about creating SimpleGenericUDAFParameterInfo. It also fixes some issue in HiveInspectors.

[flinkbot]

CI report for commit 0ab6030: ERROR Build

[lirui-apache]

I don't think the build failure is related since the failure is with blink_planner.
And CI passed on my personal repo: https://travis-ci.org/lirui-apache/flink/builds/555577813

[bowenli86]

LGTM. I've also changed the name of the jira from "Fix Hive-1.2.1 build" to "add shim of SimpleGenericUDAFParameterInfo for Hive 1.2.1 and 2.3.4". Thanks for your contribution!

Merging