Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-13287][table-api] Port ExistingField to api-java and use new Expression in FieldComputer #9129

Closed
wants to merge 4 commits into from
Closed

[FLINK-13287][table-api] Port ExistingField to api-java and use new Expression in FieldComputer #9129

wants to merge 4 commits into from

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

ExistingField is a api of table, and connectors dependent on it, we should port it to api.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@JingsongLi
Copy link
Contributor Author

@twalthr @dawidwys Can you take a look?

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 16, 2019 •
edited

CI report:

@JingsongLi JingsongLi force-pushed the ExistingField branch 3 times, most recently from b83051e to e6eaad2 Compare July 18, 2019 02:38
twalthr
twalthr approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JingsongLi. I just had minor comments.

...-table-api-java/src/main/java/org/apache/flink/table/sources/tsextractors/ExistingField.java Outdated
* a rowtime attribute.
*/
@PublicEvolving
public class ExistingField extends TimestampExtractor {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, missed it.

...able/flink-table-planner/src/main/scala/org/apache/flink/table/sources/TableSourceUtil.scala
// add cast to requested type and convert expression to RexNode
// TODO we cast to planner expressions as a temporary solution to keep the old interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readd this TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will add TODO we convert to planner expressions as a temporary solution

@JingsongLi
Copy link
Contributor Author

Travis green in: https://travis-ci.org/JingsongLi/flink/builds/560359305

@JingsongLi
Copy link
Contributor Author

JingsongLi commented Jul 18, 2019 •
edited

Thanks @twalthr 's review, Code updated and have added serialVersionUID, PublicEvolving and final. Please take a look.

@twalthr
Copy link
Contributor

twalthr commented Jul 18, 2019

Thanks. Will merge...

asfgit pushed a commit that referenced this pull request Jul 18, 2019
@JingsongLi @twalthr
[FLINK-13287][table-api] Port StreamRecordTimestamp to api-java
c43dc95 
This closes #9129.
@asfgit asfgit closed this in 2e3aab3 Jul 18, 2019
@JingsongLi JingsongLi deleted the ExistingField branch January 14, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalthr twalthr twalthr approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API review=description?
Projects
None yet
Milestone
No milestone
4 participants
@JingsongLi @flinkbot @twalthr @rmetzger