[FLINK-13304][FLINK-13322][FLINK-13323][table-runtime-blink] Fix implementation of getString and getBinary method in NestedRow, fix serializer restore in BaseArray/Map serializer and add tests for complex data formats

[tsreaper]

What is the purpose of the change

The getString and getBinary methods are not implemented correctly in NestedRow. This PR fixes the implementation and adds test cases for complex data formats.

Also, the config snapshot of BaseArray/Map serializer is not implemented correctly. When user specifies his custom kryo serializer as the element/key/value serializer and later restore the serializers from the snapshot, the element/key/value serializer may change. This PR also fixes this issue.

(This PR ought to be split into 3 PRs... I discover this problem after @wuchong reviewed this, so I'll keep this PR and let @wuchong continues his review. Sorry for the inconvenience caused)

Brief change log

• Fix implementation of getString and getBinary in NestedRow.
• Fix serializer restoring in BaseArray/Map serializer.
• Add tests for complex data formats.

Verifying this change

This change added tests and can be verified as follows: run the newly added unit tests.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 22609f1 : FAILURE Build
• 7dbec40 : SUCCESS Build
• 85740dd : PENDING Build
• eeb0b5c : FAILURE Build
• 3519a36 : SUCCESS Build
• 8e1e152 : FAILURE Build
• a2a4239 : FAILURE Build

[tsreaper]

Travis: https://travis-ci.com/TsReaper/flink/builds/119435583

The failed python tests are not related to this PR.

[JingsongLi]

Thanks @tsreaper , just left a minor comment.

[tsreaper]

Travis passed: https://travis-ci.com/TsReaper/flink/builds/119572124

[JingsongLi]

LGTM +1

[wuchong]

Thanks @tsreaper for the effort. Overall looks good to me. I left some comment regarding to the tests. Please also add some comments to the test codes to explain what's the purpose as much as possible.

[tsreaper]

Travis: https://travis-ci.com/TsReaper/flink/jobs/217472587

Note that I reverted the modification about flink-mapr-fs in this travis.

[tsreaper]

Travis: https://travis-ci.com/TsReaper/flink/builds/119956555

[wuchong]

Thanks @tsreaper . LGTM.

Could you update the corresponding PR for 1.9?

[wuchong]

The travis passed:
https://travis-ci.com/flink-ci/flink/builds/119956594
https://travis-ci.com/TsReaper/flink/builds/119956555

Merging