Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13255][hive] Skip hive connector test for JDK9 profile #9159

Closed
wants to merge 1 commit into from

Conversation

lirui-apache
Copy link
Contributor

What is the purpose of the change

Skip hive connector test for JDK9.

Brief change log

  • Skip hive tests in JDK9 profile

Verifying this change

Existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? NA

@lirui-apache
Copy link
Contributor Author

@zentol @bowenli86 @xuefuz @zjuwangg please take a look, thanks.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 18, 2019

CI report:

@zentol
Copy link
Contributor

zentol commented Jul 18, 2019

please rework the PR to work like the cassandra connector, where we handle this in the maven pom.

This fix should work for anyone using JDK 9, and not just on Travis.

@zentol zentol self-assigned this Jul 18, 2019
@zentol
Copy link
Contributor

zentol commented Jul 19, 2019

Subsumed by 311dd15.

@zentol zentol closed this Jul 19, 2019
@lirui-apache lirui-apache deleted the FLINK-13255 branch January 6, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants