Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-13286][table-api] Port connector related validators to api-java-bridge #9168

Closed
wants to merge 2 commits into from
Closed

[FLINK-13286][table-api] Port connector related validators to api-java-bridge #9168

wants to merge 2 commits into from

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

Port these class to java from scala. And remove scala apply method.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 18, 2019 •
edited

CI report:

godfreyhe
godfreyhe reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this pr @JingsongLi , LGTM (left a minor comment)

...-table-api-java-bridge/src/main/java/org/apache/flink/table/descriptors/SchemaValidator.java Outdated
// check the environment
if (!isStreamEnvironment) {
throw new ValidationException(
format("Property %s' is not allowed in a batch environment.", proctime));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nite: add ' before %s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@wuchong
Copy link
Member

wuchong commented Jul 19, 2019

Hi @JingsongLi , I think we should also move the corresponding tests to table-api or table-common, because they do not depend on planner. What do you think?

FileSystemTest -> flink-table-common
RowtimeTest -> flink-table-api-java-bridge
SchemaValidator -> flink-table-api-java-bridge

@wuchong
Copy link
Member

wuchong commented Jul 19, 2019

Others looks good to me.

@godfreyhe
Copy link
Contributor

Hi @JingsongLi , I think we should also move the corresponding tests to table-api or table-common, because they do not depend on planner. What do you think?

FileSystemTest -> flink-table-common
RowtimeTest -> flink-table-api-java-bridge
SchemaValidator -> flink-table-api-java-bridge

I think we can move java test, and scala test could be port to java in another commit.

@JingsongLi
Copy link
Contributor Author

move the corresponding tests to table-api or table-common

Good suggestion, and previous RowtimeTest and SchemaTest need port too.
@godfreyhe will port them together in the next PR.

twalthr
twalthr approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one minor comment. Otherwise +1. We haven't ported many tests yet. So its fine to do that in follow up PRs.

...table-api-java-bridge/src/main/java/org/apache/flink/table/descriptors/RowtimeValidator.java
clazz);
break;
default:
throw new RuntimeException("Unsupported rowtime timestamps type: " + t.get());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use ValidationException here and at other places where the user did something wrong

@wuchong
Copy link
Member

wuchong commented Jul 19, 2019

The travis is passed: https://travis-ci.com/flink-ci/flink/builds/119766173.
I will fix ValidationException when merging.

@asfgit asfgit closed this in 86ece85 Jul 19, 2019
asfgit pushed a commit that referenced this pull request Jul 19, 2019
@JingsongLi @wuchong
[FLINK-13286][table-api] Port RowtimeValidator and SchemaValidator to…
acb5ba5 
… api-java-bridge

This closes #9168
@JingsongLi JingsongLi deleted the validator branch July 22, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godfreyhe godfreyhe godfreyhe left review comments

@twalthr twalthr twalthr approved these changes

Assignees
No one assigned
Labels
component=TableSQL/Planner review=description?
Projects
None yet
Milestone
No milestone
6 participants
@JingsongLi @flinkbot @wuchong @godfreyhe @twalthr @rmetzger