Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13326] Support asynchronous writing to raw operator (and raw keyed) state #9171

Merged
merged 3 commits into from Jul 22, 2019

Conversation

igalshilman
Copy link
Contributor

What is the purpose of the change

Currently, the users of the AbstractStreamOperator class, are expected to complete the writing of rawKeyedOperatorState and rawOperatorState in the synchronous part of a snapshot (before the completion of snapshotState method)
But sometimes it is desirable to snapshot a custom data structure asynchronously (i.e. out side of the snapshotState method) in a similar way that the other state backends allow.

This PR adds the ability to suspend the closing of the raw states streams in snapshotState outside of the snapshotState method, and hence effectively support async snapshots for raw states.

Flink snapshotting logic already supports splitting the snapshot to sync and async parts for the various state backends, therefore the changes introduced in this PR mainly reuse that logic.

Brief change log

  • Add an interruptible close method to ResourceGuard (the default is still unInterruptible).
  • Add and use a ResourceGuard in NonClosingCheckpointOutputStream.
  • modify the StateSnapshotContextSynchronousImpl#getRaw*OperatorStateOutput to return a future that completes after all the leases were released.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Igal Shilman added 3 commits July 18, 2019 16:05
This commit adds the ability for users to indicate to Flink that the
KeyedStateCheckpointOutputStream / OperatorStateCheckpointOutputStream should be closed
at some point later in time. Previously it was expected to be closed within the synchrouns
part of AbstractStreamOperator#snapshotState.
Users might call KeyedStateCheckpointOutputStream#acquireLease(), and at some point
in the future might release the least. Once the number of leases reaches 0, the stream
would be closed.
This commit adds the ability for users to obtain a lease for the
rawOperator/rawKeyed output streams, during the synchronous part
of a snapshot, thus preventing these streaming to close.
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 18, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 27108b5 (Tue Aug 06 15:44:29 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❗ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@igalshilman
Copy link
Contributor Author

@flinkbot attention @StefanRRichter

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 19, 2019

CI report:

Copy link
Contributor

@StefanRRichter StefanRRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @igalshilman ! Changes look good to me, just tell me if/when you would like to have them merged to master :-)

@igalshilman
Copy link
Contributor Author

@StefanRRichter thanks! I'm ok with merging it.

@StefanRRichter StefanRRichter merged commit c75af84 into apache:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants