[FLINK-13393][FLINK-13391][table-planner-blink] Fix source conversion and source return type #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7dfc563 (Tue Aug 06 15:51:20 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tsreaper
approved these changes
Jul 24, 2019
… getReturnType of TableSource
wuchong
pushed a commit
to wuchong/flink
that referenced
this pull request
Jul 26, 2019
…rk in blink planner The reason is that blink-planner use TypeExtractor to extract class from TableSource, and use this class to DataFormatConverter. However, blink should use conversion class of DataType in TableSource#getProducedDataType. This closes apache#9211
wuchong
reviewed
Jul 26, 2019
There was a problem hiding this comment.
Thanks @JingsongLi for the effort. Overall looks good to me.
I only left a comment about InputFormatTableSource.
| streamEnv: StreamExecutionEnvironment): Transformation[_] = { | ||
| if (sourceTransform == null) { | ||
| sourceTransform = tableSource match { | ||
| case source: InputFormatTableSource[_] => |
There was a problem hiding this comment.
I think the problem is InputFormatTableSource#getDataStream shouldn't call getReturnType, the following code should be moved to there.
|
However, I can do the change and verify in my repo travis and merge this. |
asfgit
pushed a commit
that referenced
this pull request
Jul 26, 2019
…rk in blink planner The reason is that blink-planner use TypeExtractor to extract class from TableSource, and use this class to DataFormatConverter. However, blink should use conversion class of DataType in TableSource#getProducedDataType. This closes #9211
wzhero1
pushed a commit
to wzhero1/flink
that referenced
this pull request
Aug 2, 2019
…rk in blink planner The reason is that blink-planner use TypeExtractor to extract class from TableSource, and use this class to DataFormatConverter. However, blink should use conversion class of DataType in TableSource#getProducedDataType. This closes apache#9211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1.Blink-planner should use conversion class of DataType
2.Blink-planner should not invoke deprecated getReturnType of TableSource
Verifying this change
TableSourceITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation