[FLINK-13228][tests][filesystems] Harden HadoopRecoverableWriterTest

[carp84]

What is the purpose of the change

Currently test cases will fail when trying to close the output stream if all data written but ClosedByInterruptException occurs at the ending phase. This PR proposes to close the stream silently if the test case logic passed properly.

Brief change log

Close the output stream silently in HadoopRecoverableWriterTest if the test case logic passed properly.

Verifying this change

This change is on the test cases and verified by sanity test through modifying hadoop source code to simulate the rarely happening situation that triggers the issue.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4a0eae0 (Tue Aug 06 15:52:36 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❗ 3. Needs [attention] from.
  • Needs attention by @StephanEwen [PMC], @tillrohrmann [PMC]
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[carp84]

This should be able to resolve FLINK-12071 also.

@flinkbot attention @tillrohrmann @StephanEwen

[flinkbot]

CI report:

• 1c65be3 : FAILURE Build
• e91a171 : SUCCESS Build
• 4a0eae0 : SUCCESS Build

[carp84]

Thanks for helping fix the checkstyle issue @zentol !

[StephanEwen]

FYI: You can use IOUtils.closeQuietly(...) for this as well.

[carp84]

Thanks for the reminder @StephanEwen , I thought it might be useful to log the exception out at debug level but yes we could also manually change it when need to debug, will change to use IOUtils.closeQuietly

[StephanEwen]

Looks good, thanks.
Merging this...