[FLINK-13396] Deprecate the BucketingSink.

[kl0u]

What is the purpose of the change

It marks the BucketingSink as deprecated in favour of the StreamingFileSink and updates the documentation accordingly.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 85422f4 (Tue Aug 06 15:55:30 UTC 2019)

Warnings:

• Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 8e3b712 : SUCCESS Build
• cd162ff : SUCCESS Build
• 85422f4 : FAILURE Build

[wuchong]

Looks good to me.

[zentol]

let'S add a link to the documentation of the StreamingFileSink

[kl0u]

Done.

[kl0u]

Thanks for the review @wuchong !
I integrated your comment @zentol . Let me know what you think.

[mzuehlke]

Just some tiny comments:

• should the org.apache.flink.streaming.connectors.fs.bucketing.Bucketer be deprecated, too ?
• In the package org.apache.flink.streaming.api.functions.sink are some already deprecated classes that point to the now also deprecated BucketingSink: @deprecated Please use the {@code BucketingSink} for writing to files from a streaming program. Not ideal from a user perspective.

[kl0u]

Thanks for looking into it @mzuehlke . I integrated your comments. Let me know if I forgot anything.

[mzuehlke]

Thanks for the update. 👍 from my side

[kl0u]

@zentol do you have any further comments?

[aljoscha]

I think this looks good to merge now! 👌

[kl0u]

Thanks for the reviews. Merged.