-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13386][web]: Fix frictions in the new default Web Frontend #9247
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 89e02cd (Wed Oct 16 08:32:27 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Hi @vthinkxie All points beside I can't really check the PR contents as I am not very familiar with the frontend technology. Will try to ask a friend for that. |
Hi @dawidwys |
@dawidwys could you check this, and when there are too many vertexes, the web ui will request too many requests to the REST API, I have created another jira here https://issues.apache.org/jira/browse/FLINK-14147, I think we can merge this PR first, since it may need long time to resolve the jira. |
Codewise this looks good to me. @dawidwys could you verify the functionality then we can call this good? |
I verified the ui and it looks good... merging. |
Fix frictions in the new default Web Frontend
https://issues.apache.org/jira/browse/FLINK-13386
What is the purpose of the change
Fix below bugs
There are also some views missing in the new UI that I personally found useful in the old UI:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation