[FLINK-13447][table-api] Change default planner to legacy planner instead of any one

[wuchong]

What is the purpose of the change

We want to change the default behavior of the EnvironmentSettings to use old planner instead of any planner. This will enable us to have both planner in the classpath by default. This will also enable users/connectors to have both planner in dependency and without using EnvironmentSettings explicitly.

Brief change log

Update EnvironmentSettings to use old planner instead of any planner by default.

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4ac3a6f (Tue Aug 06 15:53:49 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• be35c02 : FAILURE Build
• 75871fb : FAILURE Build
• 9a59b9a : FAILURE Build
• 4ac3a6f : FAILURE Build

[dawidwys]

Hi @wuchong . Thank you for the PR. I put one comment regarding javadocs.

[dawidwys]

Please update the javadoc: By default, {@link #useAnyPlanner()} is -> By default, {@link #useOldPlanner()} is. Also in the remaining two methods.

[wuchong]

Good catch!

[dawidwys]

I think it's good to go now.

[wuchong]

Travis passed: https://travis-ci.org/wuchong/flink/builds/564895873

Merging

[twalthr]

Nevermind, my Github view was not updated.