[FLINK-13427][hive] HiveCatalog's createFunction fails when function …

[lirui-apache]

…name has upper-case characters

What is the purpose of the change

To fix the issue that function name is not normalized in HiveCatalog.

Brief change log

• Normalize function name when a Hive function is created.
• Added a common base class for HiveCatalogHiveMetadataTest and HiveCatalogGenericMetadataTest. And a new test case to make sure HiveCatalog is case-insensitive when creating a function.

Verifying this change

New test case added.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? NA

[lirui-apache]

cc @JingsongLi @KurtYoung @xuefuz @zjuwangg

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 9ab2841 : FAILURE Build
• 4578d78 : FAILURE Build
• 41959ed : SUCCESS Build

[xuefuz]

+1.

The CI failures seem unrelated to changes made here.

[lirui-apache]

The latest CI succeeded.
@wuchong would you mind help review and merge this PR? Thanks.

[wuchong]

Looks good to me.

Will merge this.