[FLINK-2205] Fix confusing entries in JM UI Job Config. section #927
Conversation
ebautistabar
force-pushed
the
change-job-config-display
branch
from
ba7534c
to
e64f5ef
Compare
|
Hi @ebautistabar, thanks for the pull request! |
|
The job manager UI is under rework right now, there is a new version coming up, see here: https://github.com/apache/flink/tree/master/flink-runtime-web This fix (if going to the old UI) would be only temporary... |
Default display for 'Number of execution retries' is now 'deactivated' and for 'Job parallelism' is 'auto', as suggested in JIRA.
ebautistabar
force-pushed
the
change-job-config-display
branch
from
e64f5ef
to
d957523
Compare
|
Hi @fhueske, @StephanEwen, I wasn't aware of that. Just picked a starter issue to get my feet wet. I've added the other suggested change, in case you decide to merge this while you finish the new UI. If not, please feel free to close the PR (and maybe the Jira issue, if this has already been dealt with in the new dashboard code). |
|
@ebautistabar you're the only one who can close the PR. But maybe the new web interface needs the same fixes as you've proposed for the old UI. |
|
I think you can actually add the code to the current UI. It is not going to disappear in the near future, it will probably stay as a fallback variant for one more version. You can add this functionality there. Adding it to the new web frontend is a separate effort. If you want, you can be involved there as well. |
|
Great. I'll add the changes to the new frontend too. Thanks. |
|
As the new UI didn't show job configurations yet, I have created another PR (#953) to deal with it, which also includes the display changes requested in FLINK-2205. |
|
This PR is fixing the older UI and still valid, right? |
|
I think it is good to merge. The patch for the new UI has already been merged... |
|
Merging |
…ion. Default display for 'Number of execution retries' is now 'deactivated' and for 'Job parallelism' is 'auto', as suggested in JIRA. This closes apache#927
…ion. Default display for 'Number of execution retries' is now 'deactivated' and for 'Job parallelism' is 'auto', as suggested in JIRA. This closes apache#927
|
Changes Unknown when pulling d957523 on ebautistabar:change-job-config-display into ** on apache:master**. |
…aryTest (#927) * [FLINKCC-1328] Follow up to add more udf join test cases to QuerySummaryTest
Default display for 'Number of execution retries' is now 'deactivated' and for 'Job parallelism' is 'auto', as suggested in JIRA.