Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13455][build] Move jdk.tools exclusions out of dependency management #9292

Merged
merged 1 commit into from Jul 31, 2019

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Jul 31, 2019

This PR moves the jdk.tools exclusions out of the dependency management and directly attaches them to the dependencies.

These exclusions exist since this dependency does not exist on Java 9+.

The shade-plugin interacts oddly with exclusions defined in the dependency management; it still attempts to resolve them when building the dependency reduced pom, iff they are defined for transitive dependencies, which can result in build failures. Note that this behavior may be either coupled to Java 11, or the 3.2.1 version of the shade-plugin.

Since jdk.tools is a system-provided dependency that is either on the classpath or not, depending on the JDK version, there should be no effective difference to any of the effected modules.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 13bcdfd (Fri Aug 23 10:14:30 UTC 2019)

Warnings:

  • 7 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2019

CI report:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants