Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13519] [docs] Rewrite Elasticsearch 6.x example for Scala to use RuntimeContext and RequestIndexer #9309

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

a-romero
Copy link
Contributor

@a-romero a-romero commented Jul 31, 2019

What is the purpose of the change

Rewrite Elasticsearch 6.x example for Scala to use RuntimeContext and RequestIndexer

Brief change log

The Scala example in the documentation for the Elasticsearch Connector, version 6.x, will not build. The class ElasticsearchSinkFunction[String] requires a RuntimeContext and a RequestIndexer, which the example omits.

Also, type needs to be in inverse quotes as it's a Scala keyword.

new ElasticsearchSinkFunction[String] {
    def process(element: String, ctx: RuntimeContext, indexer: RequestIndexer) {
    ...
    val rqst: IndexRequest = Requests.indexRequest
        .index("my-index")
        .`type`("my-type")
        .source(json)

    indexer.add(rqst)
    }
}

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e7fe8ef (Thu Oct 24 18:04:45 UTC 2019)

Warnings:

  • Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 31, 2019

CI report:

@a-romero
Copy link
Contributor Author

a-romero commented Sep 9, 2019

Hi @rmetzger , just wondering if this is ok to merge now?

@zentol zentol self-assigned this Oct 23, 2019
@@ -250,15 +250,17 @@ httpHosts.add(new HttpHost("10.2.3.1", 9200, "http"))
val esSinkBuilder = new ElasticsearchSink.Builer[String](
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val esSinkBuilder = new ElasticsearchSink.Builer[String](
val esSinkBuilder = new ElasticsearchSink.Builder[String](

@zentol zentol changed the title FLINK-13519 [docs] Rewrite Elasticsearch 6.x example for Scala to use RuntimeContext and RequestIndexer [FLINK-13519] [docs] Rewrite Elasticsearch 6.x example for Scala to use RuntimeContext and RequestIndexer Oct 23, 2019
@zentol zentol merged commit 1cf261e into apache:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants