Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13530][qs][tests] Increase port range size #9317

Merged
merged 1 commit into from Aug 15, 2019
Merged

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Aug 1, 2019

Increase the size of the port range used in AbstractServerTest#testPortRangeSuccess by 4000%, which should make it quite likely that we find an open port; should the test fail again for the same reason we can conclude that there is an actual problem in the code.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 1, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9d613db (Tue Aug 27 09:12:52 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 1, 2019

CI report:

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @zentol. LGTM. +1 for merging.

@tillrohrmann
Copy link
Contributor

The test failure seems to be unrelated. Re-opened FLINK-9900 for this.

@zentol zentol merged commit 0bd5c53 into apache:master Aug 15, 2019
@zentol zentol deleted the 13530 branch August 15, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants