-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13541][state-processor-api] State Processor Api sets the wrong key selector when writing savepoints #9324
Conversation
… key selector when writing savepoints
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 75ce1d9 (Tue Aug 06 15:56:36 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
… key selector when writing savepoints This closes apache#9324
… key selector when writing savepoints This closes apache#9324
Thanks, @sjwiesman The fix looks good to me. Rebasing and merging this... |
… key selector when writing savepoints This closes #9324
… key selector when writing savepoints This closes apache#9324
… key selector when writing savepoints This closes apache#9324
What is the purpose of the change
The state processor api is setting the wrong key selector for its StreamConfig when writing savepoints. It uses two key selectors internally that happen to output the same value for integer keys but not in general.
Brief change log
Verifying this change
UT
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation