[FLINK-2385] [scala api] [api breaking] Add parenthesis to Scala 'distinct' transformation. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanEwen
changed the title
StephanEwen
force-pushed
the
scala_distinct
branch
from
828761a
to
8b0fd79
Compare
|
Any reservation against this? (The one failed build profile is due to a Travis hiccup) |
|
Nope. +1 from my side. |
StephanEwen
added a commit
to StephanEwen/flink
that referenced
this pull request
Jul 23, 2015
nikste
pushed a commit
to nikste/flink
that referenced
this pull request
Sep 29, 2015
nltran
pushed a commit
to nltran/flink
that referenced
this pull request
Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation is not side-effect free. It does not mutate the original DataSet, but defines distributed computation.
This pull request also removes a test that was testing behavior that is now supported, but that was not recognized because the method call was matched against the wrong overloaded method.
This pull request also correct some comment markups.