[FLINK-13562] [table-planner-blink] fix incorrect input type for local stream group aggregate in FlinkRelMdColumnInterval #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2095dae (Fri Aug 23 10:16:01 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
wuchong
reviewed
Aug 8, 2019
| @@ -117,6 +117,11 @@ class DistinctAggregateTest( | |||
| util.verifyPlan(sqlQuery) | |||
| } | |||
|
|
|||
| @Test | |||
| def testTwoDistinctAggregateWithNonDistinctAgg(): Unit = { | |||
| util.verifyPlan("SELECT c, SUM(DISTINCT a), SUM(a), COUNT(DISTINCT b) FROM MyTable GROUP BY c") | |||
There was a problem hiding this comment.
What's purpose of this test? Will it fail without the fix?
There was a problem hiding this comment.
yes, to verify the bug
wuchong
approved these changes
Aug 9, 2019
…l stream group aggregate in FlinkRelMdColumnInterval
wuchong
pushed a commit
to wuchong/flink
that referenced
this pull request
Aug 9, 2019
… stream group aggregate in FlinkRelMdColumnInterval This closes apache#9346
|
Waiting for travis passing: https://travis-ci.org/wuchong/flink/builds/569693450 |
rebased |
|
Merging |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2019
… stream group aggregate in FlinkRelMdColumnInterval This closes #9346
becketqin
pushed a commit
to becketqin/flink
that referenced
this pull request
Aug 17, 2019
… stream group aggregate in FlinkRelMdColumnInterval This closes apache#9346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix incorrect input type for local stream group aggregate in FlinkRelMdColumnInterval
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation