Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13610][hive]Refactor HiveTableSource Test use sql query and remove HiveInputFormatTest #9379

Closed
wants to merge 1 commit into from

Conversation

zjuwangg
Copy link
Contributor

@zjuwangg zjuwangg commented Aug 7, 2019

What is the purpose of the change

Refactor HiveTableSourceTest use sql query and remove HiveInputFormatTest

Brief change log

  • change HiveTableSourceTest using sql way instead of table api.
  • move hiveintputformattest into HiveTableSourceTest and remove this file
  • remove unnecessary test file

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zjuwangg
Copy link
Contributor Author

zjuwangg commented Aug 7, 2019

cc @xuefuz @lirui-apache to help review.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5ca9937 (Wed Aug 07 21:55:37 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2019

CI report:

Copy link
Contributor

@lirui-apache lirui-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xuefuz xuefuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 886419f Aug 7, 2019
asfgit pushed a commit that referenced this pull request Aug 7, 2019
…move HiveInputFormatTest

Refactor HiveTableSourceTest use sql query and remove HiveInputFormatTest

This closes #9379
@zjuwangg zjuwangg deleted the FLINK-13610 branch August 8, 2019 01:50
becketqin pushed a commit to becketqin/flink that referenced this pull request Aug 17, 2019
…move HiveInputFormatTest

Refactor HiveTableSourceTest use sql query and remove HiveInputFormatTest

This closes apache#9379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants