Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13637][docs] Fix problems of anchors in document(building.md, common.md, queryable_state.md) #9384

Closed
wants to merge 1 commit into from

Conversation

hequn8128
Copy link
Contributor

What is the purpose of the change

This pull request fixes problems of anchors in documents(building.md, common.md, queryable_state.md).

The format should be:
[create an anchor](#anchors-in-markdown)

  • Add - characters between each word in the heading and wrap the value in parens
  • All letters should be lowercase.

Brief change log

  • Change letters to lowercase in queryable_state.md and common.md.
  • Add - characters between each word for the anchors in building.md.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5aa026a (Fri Aug 23 10:15:33 UTC 2019)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2019

CI report:

@dianfu
Copy link
Contributor

dianfu commented Aug 8, 2019

Good catch! +1

@hequn8128
Copy link
Contributor Author

@dianfu Thank you. I'll merge this...
@flinkbot approve all

hequn8128 added a commit to hequn8128/flink that referenced this pull request Aug 8, 2019
@hequn8128 hequn8128 closed this in 56c6b48 Aug 9, 2019
hequn8128 added a commit that referenced this pull request Aug 9, 2019
becketqin pushed a commit to becketqin/flink that referenced this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants