New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13611] [table-planner-blink] Introduce statistic generator utility to generate table & column statistics #9392
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 873811b (Thu Oct 24 18:04:17 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
I also tried to write something like that and the problem I had was that the computatio of column stats, if computed independently, is not so efficient (all the values of a column is read by every stat function while you could just read the values once and compute all the statistics in one big function). |
thanks for the feedback @fpompermaier . currently, this pr only supports simple statistics which are defined in |
07d04ce
to
96d8b4c
Compare
the PR is helpful for me,thanks @godfreyhe |
@godfreyhe |
…s is lost in RelTimeIndicatorConverter"
…ing table stats and column stats
…rting TableStats to CatalogTableStatistics and CatalogColumnStatistics
96d8b4c
to
873811b
Compare
@leonardBang I had rebased, thanks for the review |
What is the purpose of the change
Introduce statistic generator utility to generate table & column statistics
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation