Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13739][table-blink] JDK String to bytes should specify UTF-8 encoding #9455

Closed
wants to merge 2 commits into from

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

The reason should be that the default encoding of the machine is not UTF-8, and the test relies on the default encoding.
The code should use the specified UTF-8 encoding

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector:no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 15, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e628a7a (Fri Aug 23 10:20:00 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 15, 2019

CI report:

@rmetzger
Copy link
Contributor

I'm testing the change

@rmetzger
Copy link
Contributor

[INFO] Results:
[INFO]
[INFO] Tests run: 668, Failures: 0, Errors: 0, Skipped: 0

Looks like this PR is fixing the issue.

@JingsongLi
Copy link
Contributor Author

JingsongLi commented Aug 16, 2019

Thanks @rmetzger for verification, ping @wuchong to review

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing @JingsongLi . It looks good to me.

I will merge it.

@asfgit asfgit closed this in 130f4e8 Aug 18, 2019
asfgit pushed a commit that referenced this pull request Aug 18, 2019
@JingsongLi JingsongLi deleted the utf8-bug branch August 19, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants