New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13868][REST] Job vertex add taskmanager id in rest api #9555
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 125c6a2 (Fri Sep 06 09:12:27 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
8dd191e
to
fc91d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks fine, but we're mixing 2 separate changes in a single commit (addition of new field, and deduplicating classes).
...runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexDetailsHandler.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @jinglining. I had some minor comments. The main question is whether the changes to rest_api_v1.snapshot
are actually backwards compatible. For that to verify I'd like to hear @zentol opinion.
...main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfoTest.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfoTest.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfoTest.java
Outdated
Show resolved
Hide resolved
fc91d03
to
dde86e8
Compare
I hava updated the commit, delete change for deduplicating classes. And I'll open other jira for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this PR @jinglining. The changes look now good to me. Merging once @zentol gives his ok wrt backwards compatibility. But since we only added a field, I assume that it is ok.
I have fixed it. |
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfo.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, waiting for Travis.
@flinkbot run travis |
Merging this PR now. |
What is the purpose of the change
This pull request makes user can get ResourceId from vertex's subtask in rest api.
Brief change log
Verifying this change
This change is already covered by existing tests, such as SubtaskCurrentAttemptDetailsHandlerTest,SubtaskExecutionAttemptDetailsHandlerTest, SubtaskExecutionAttemptDetailsInfoTest, JobVertexDetailsInfoTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation