Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy #9688

Closed

Conversation

zhuzhurk
Copy link
Contributor

@zhuzhurk zhuzhurk commented Sep 16, 2019

What is the purpose of the change

Currently some region boundary structures are calculated each time of a region failover. This calculation can be heavy as its complexity goes up with execution edge count.
This PR is to introduce FastRestartPipelinedRegionStrategy which has better failover handling performance at the cost of slower region building and more memory used.

More details and testing results can be found at FLINK-13056.

Brief change log

  • Added FastRestartPipelinedRestartStrategy

Verifying this change

  • Unit test added

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 16, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bea922d (Wed Dec 04 14:50:21 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 16, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you configure the FastRestartPipelinedRegionStrategy?

@tillrohrmann
Copy link
Contributor

@zhuzhurk the PR does not seem to compile.

@zhuzhurk
Copy link
Contributor Author

zhuzhurk commented Sep 17, 2019

How do you configure the FastRestartPipelinedRegionStrategy?

The PR is updated to enable configuring the new strategy.
A new valid value "region-fast" is added for config "jobmanager.execution.failover-strategy".

@zhuzhurk
Copy link
Contributor Author

@zhuzhurk the PR does not seem to compile.

The compile fails due to dependency retrieval errors that "GET request of: org/scala-lang/scala-library/2.11.11/scala-library-2.11.11.jar from google-maven-central failed: Connection reset".
I guess a retry should help.

@zhuzhurk zhuzhurk changed the title [FLINK-13056] [runtime] Introduce FastRestartPipelinedRegionStrategy which has better failover handling performance at the cost of slower region building and more memory used [FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy Sep 24, 2019
@zhuzhurk zhuzhurk force-pushed the FLINK_13056_region_failover_optimized branch from 23278b6 to 5831d97 Compare September 25, 2019 12:45
@zhuzhurk
Copy link
Contributor Author

@flinkbot run travis

@zhuzhurk zhuzhurk force-pushed the FLINK_13056_region_failover_optimized branch from 5831d97 to 5c1518e Compare September 26, 2019 07:46
This strategy has better failover handling performance over RestartPipelinedRegionStrategy.
The side effect is slower region building and more cache in memory.
@zhuzhurk zhuzhurk force-pushed the FLINK_13056_region_failover_optimized branch from 5c1518e to ef600d0 Compare October 29, 2019 02:51
@zhuzhurk zhuzhurk force-pushed the FLINK_13056_region_failover_optimized branch from ef600d0 to bea922d Compare October 29, 2019 03:59
@zhuzhurk
Copy link
Contributor Author

zhuzhurk commented Aug 3, 2022

The change is already covered in the performance improvements of scheduler and this PR is not needed.

@zhuzhurk zhuzhurk closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants