New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy #9688
[FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy #9688
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit bea922d (Wed Dec 04 14:50:21 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you configure the FastRestartPipelinedRegionStrategy
?
@zhuzhurk the PR does not seem to compile. |
The PR is updated to enable configuring the new strategy. |
The compile fails due to dependency retrieval errors that "GET request of: org/scala-lang/scala-library/2.11.11/scala-library-2.11.11.jar from google-maven-central failed: Connection reset". |
23278b6
to
5831d97
Compare
@flinkbot run travis |
5831d97
to
5c1518e
Compare
This strategy has better failover handling performance over RestartPipelinedRegionStrategy. The side effect is slower region building and more cache in memory.
5c1518e
to
ef600d0
Compare
ef600d0
to
bea922d
Compare
The change is already covered in the performance improvements of scheduler and this PR is not needed. |
What is the purpose of the change
Currently some region boundary structures are calculated each time of a region failover. This calculation can be heavy as its complexity goes up with execution edge count.
This PR is to introduce FastRestartPipelinedRegionStrategy which has better failover handling performance at the cost of slower region building and more memory used.
More details and testing results can be found at FLINK-13056.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation