Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-14216][table] introduce temp system functions to FunctionCatalog #9822

Closed
wants to merge 5 commits into from
Closed

[FLINK-14216][table] introduce temp system functions to FunctionCatalog #9822

wants to merge 5 commits into from

Conversation

bowenli86
Copy link
Member

@bowenli86 bowenli86 commented Sep 30, 2019 •
edited

What is the purpose of the change

adapt existing APIs to the introduction of temporary system and temp functions according to FLIP-57

611ecde - introduce temp system functions and adapt existing APIs
cc357e4 - introduce temp functions and corresponding APIs

Brief change log

  • renamed registerXxxFunction() to registerTemporarySystemXxxFunction()
  • renamed variable userFunctions in FunctionCatalog to tempSystemFuncitons
  • added registerTemporaryXxxFunction() APIs

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs / JavaDocs)

docs will be added separately

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 30, 2019 •
edited

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ad05fac (Wed Oct 16 08:44:32 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 30, 2019 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@bowenli86
Copy link
Member Author

@xuefuz @lirui-apache @zjuwangg

@bowenli86
Copy link
Member Author

@xuefuz can you take a look?

xuefuz
xuefuz reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@xuefuz xuefuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had a couple of minor comments/questions. For the newly added methods, should we have tests covering them?

...table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
Comment on lines +317 to +318
oi.getCatalogName(),
oi.getDatabaseName(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to normalize the cat/db names as well, if they are case insensitive.

Copy link
Member Author

@bowenli86 bowenli86 Oct 9, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently catalog/db names are case sensitive in Flink. We haven't any normalization so far yet. I imagine we will be relying on the case sensitivity flag that should be introduced in Flink planner in the future.

For function name, it's a bit different as the existing code always normalize function name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. sounds good.

...table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java Outdated
Comment on lines 145 to 147
ObjectIdentifier oi,
TableFunction<T> function,
TypeInformation<T> resultType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tab indention?

...table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java Outdated
Comment on lines 164 to 166
UserDefinedAggregateFunction<T, ACC> function,
TypeInformation<T> resultType,
TypeInformation<ACC> accType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@bowenli86
Copy link
Member Author

@xuefuz thanks for your review! Tests will be added in the next PRs that introduce ambiguous/precise function reference

xuefuz
xuefuz approved these changes Oct 9, 2019
View reviewed changes
...table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
Comment on lines +317 to +318
oi.getCatalogName(),
oi.getDatabaseName(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. sounds good.

@bowenli86
Copy link
Member Author

@flinkbot run travis

1 similar comment
@bowenli86
Copy link
Member Author

@flinkbot run travis

@asfgit asfgit closed this in b24e4bc Oct 15, 2019
@bowenli86 bowenli86 deleted the tempsys branch October 15, 2019 22:58
zhuzhurk pushed a commit to zhuzhurk/flink that referenced this pull request Oct 18, 2019
@bowenli86 @zhuzhurk
[FLINK-14216][table] introduce temp system functions and temp functio…
83d978c 
…ns to FunctionCatalog

adapt existing APIs to the introduction of temporary system and temp functions according to FLIP-57.

This closes apache#9822.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuefuz xuefuz xuefuz approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API review=description?
Projects
None yet
Milestone
No milestone
4 participants
@bowenli86 @flinkbot @xuefuz @rmetzger