[FLINK-14299] Introduce ProcessMetricGroup #9825
Conversation
The ProcessMetricGroup encapsulates the Status and system metrics of the ClusterEntrypoint. These have been factored out of the JobManagerMetricGroup. In order to maintain backwards compatibility, the same scope as the JobManagerMetricGroup is being used.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6039a68 (Wed Oct 16 08:34:54 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
| private static MetricGroup createAndInitializeStatusMetricGroup(AbstractMetricGroup<?> parentMetricGroup) { | ||
| MetricGroup statusGroup = parentMetricGroup.addGroup(METRIC_GROUP_STATUS_NAME); | ||
|
|
||
| // Initialize the TM metrics |
There was a problem hiding this comment.
this comment isn't accurate anymore; let's just remove it
There was a problem hiding this comment.
true, I will remove it.
| @@ -62,7 +64,7 @@ | |||
| */ | |||
| public class MetricUtils { | |||
| private static final Logger LOG = LoggerFactory.getLogger(MetricUtils.class); | |||
| private static final String METRIC_GROUP_STATUS_NAME = "Status"; | |||
| public static final String METRIC_GROUP_STATUS_NAME = "Status"; | |||
There was a problem hiding this comment.
where is this used outside of this class?
There was a problem hiding this comment.
This is wrong. Will correct it.
|
Thanks for the review @zentol. I've addressed your comments and pushed a fixup. |
|
Merged. |
What is the purpose of the change
The ProcessMetricGroup encapsulates the Status and system metrics of the ClusterEntrypoint.
These have been factored out of the JobManagerMetricGroup. In order to maintain backwards
compatibility, the same scope as the JobManagerMetricGroup is being used.
cc @zentol
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation