New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14305] Transfer ownership of JobManagerMetricGroup to Dispatcher #9828
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5c23b74 (Wed Oct 16 08:35:05 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
582fcdf
to
12bfe6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (excluding commits from previous PRs)
12bfe6e
to
7529618
Compare
The ProcessMetricGroup encapsulates the Status and system metrics of the ClusterEntrypoint. These have been factored out of the JobManagerMetricGroup. In order to maintain backwards compatibility, the same scope as the JobManagerMetricGroup is being used.
The AbstractImitatingJobManagerMetricGroup imitates the reporting of the JobManagerMetricGroup and can be used for metrics which are factored out of the JobManagerMetricGroup without breaking backwards compatibility wrt the reported metrics.
Introduce a new metric group called ResourceManagerMetricGroup which can be used to report ResourceManager specific metrics.
…agerMetricGroup in ResourceManager With this commit, the ResourceManager uses the ResourceManagerMetricGroup to register its metrics.
With this commit the Dispatcher is now responsible for managing the lifecycle of the JobManagerMetricGroup.
7529618
to
5c23b74
Compare
Merged. |
What is the purpose of the change
This PR is based on #9827
With this commit the Dispatcher is now responsible for managing the lifecycle of
the JobManagerMetricGroup.
cc @zentol
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation