Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14319][api] Register user jar files in execution environment. #9841

Closed
wants to merge 5 commits into from

Conversation

mr-cloud
Copy link
Contributor

@mr-cloud mr-cloud commented Oct 4, 2019

What is the purpose of the change

Add interfaces in {Stream}ExecutionEnviroment to allow people to register user jar files in an execution environment.

Brief change log

  • Add interface registerUserJarFile() for StreamExecutionEnvironment both for Java and Scala API.
  • Add interface registerUserJarFile() for ExecutionEnvironment both for Java and Scala API.

Verifying this change

This change added tests and can be verified as follows:

  • User jar in local can be tested with AddingUserJarTest.java.
  • User jar in a distributed file system like HDFS can be tested with UserJarDfsTest.java.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a9d0502 (Wed Oct 16 08:38:32 UTC 2019)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 4, 2019

CI report:

@mr-cloud
Copy link
Contributor Author

mr-cloud commented Oct 5, 2019

The CI reports a build failure because of the lack of licenses for some files. I added licenses for them now. Please continue :-). @rmetzger

@mr-cloud
Copy link
Contributor Author

mr-cloud commented Oct 6, 2019

All parts of the building are successful except that python APICompletenessTestCases for {Stream}ExecutionEnvironment failed as missing the API declared in Java's. Maybe we can implement the APIs for python in another issue. What's your option? @rmetzger @HuangZhenQiu

@zentol zentol closed this Oct 7, 2019
@zentol
Copy link
Contributor

zentol commented Oct 7, 2019

Please wait for consent of the community before opening a PR.

@mr-cloud
Copy link
Contributor Author

mr-cloud commented Oct 9, 2019

Thanks. The PR is closed for now. And I proposed a plan detail for design and testing. Let's discuss first. Please review that and vote for this issue if it's reasonable. @zentol @HuangZhenQiu @rmetzger
issue address: https://issues.apache.org/jira/browse/FLINK-14319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants