-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14319][api] Register user jar files in execution environment. #9841
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a9d0502 (Wed Oct 16 08:38:32 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
The CI reports a build failure because of the lack of licenses for some files. I added licenses for them now. Please continue :-). @rmetzger |
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/userjar/UserJarDfsTest.java
Outdated
Show resolved
Hide resolved
All parts of the building are successful except that python APICompletenessTestCases for {Stream}ExecutionEnvironment failed as missing the API declared in Java's. Maybe we can implement the APIs for python in another issue. What's your option? @rmetzger @HuangZhenQiu |
Please wait for consent of the community before opening a PR. |
Thanks. The PR is closed for now. And I proposed a plan detail for design and testing. Let's discuss first. Please review that and vote for this issue if it's reasonable. @zentol @HuangZhenQiu @rmetzger |
What is the purpose of the change
Add interfaces in {Stream}ExecutionEnviroment to allow people to register user jar files in an execution environment.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
AddingUserJarTest.java
.UserJarDfsTest.java
.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation