Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14454] [test-stability] Usages of SavepointSerializers.setFailWhenLegacyStateDetected are never reverted #9944

Closed
wants to merge 1 commit into from

Conversation

Jiayi-Liao
Copy link
Contributor

What is the purpose of the change

Re-enable FAIL_WHEN_LEGACY_STATE_DETECTED after all state migration tests.

Brief change log

Adding the revert logic in a @afterclass method.

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 20, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 605ff45 (Wed Dec 04 14:49:25 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 20, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@Jiayi-Liao
Copy link
Contributor Author

@flinkbot run travis

@StephanEwen
Copy link
Contributor

Thank you for the patch. Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 7, 2019
@asfgit asfgit closed this in 8caea1a Dec 8, 2019
@Jiayi-Liao Jiayi-Liao deleted the unittest branch February 14, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants