FLUME-3347:Direct buffer memory causes sink thread to die #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mpercy Can you help me review? |
|
@bessbd can you please review? |
bessbd
reviewed
Dec 7, 2019
|
Thank you for the patch, @lightzhao ! The idea for this change sounds good. Unfortunately, without the right justification, this code probably should not be merged. Can you please think of an alternative improvement? |
mpercy
requested changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the java.lang.OutOfMemoryError: Direct buffer memory exception occurs in the hdfsSink thread, the exception is thrown to the SinkRunner thread, but the SinkRunner thread does not catch the Throwable exception, causing the hdfsSink thread to die。