Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muchos needs to be updated for new log4j2 config files #344

Closed
arvindshmicrosoft opened this issue May 6, 2020 · 3 comments
Closed

Muchos needs to be updated for new log4j2 config files #344

arvindshmicrosoft opened this issue May 6, 2020 · 3 comments

Comments

@arvindshmicrosoft
Copy link
Member

Follow-up issue to track an observation raised during review of #343 - when accumulo-2.1.0-SNAPSHOT is used, variables like accumulo.log.dir are not being expanded properly and as a result the Accumulo log directory names are literally set as ${accumulo.log.dir} and so on. This is possibly related to the Accumulo changes to switch to log4j2 so we need to handle those in Muchos for 2.1.0 and above.

@ctubbsii
Copy link
Member

ctubbsii commented May 7, 2020

Could the root of this problem be that Muchos is attempting to override accumulo-env.sh with its own ansible/roles/accumulo/templates/accumulo-env.sh, which sets up its own ansible/roles/accumulo/templates/log4j-service.properties?

It's possible log4j2 is trying to do some backwards-compatible log4j1 config file parsing, since log4j2 jars are on the classpath for 2.1.0-SNAPSHOT, but not succeeding for some reason.

A good fix might update Muchos' version of accumulo-env.sh to be based on the one in the 2.1.0-SNAPSHOT, and similarly, use different log4j2 config files, closer to those in the 2.1.0-SNAPSHOT source.

Separate, but related, issue: Since Muchos is trying to override log configuration explicitly anyway, I think it would probably be better if Muchos' log4j settings just used the system logger, and instead of trying to output to ${accumulo.log.dir}. Ideally, Muchos would only support systemd, and the config file would just log stuff to the console, which is automatically captured by journald, and it wouldn't use any file-based log settings at all. The file-based logging solution is really for out-of-the-box Accumulo installs... a curated deployment using something like Muchos can use smarter approaches to log collection, by leveraging the deployed environment's tooling for log collection maintained by the system admin (journald, syslog, etc.).

@keith-turner
Copy link
Contributor

@arvindshmicrosoft I am interested in fixing this, but I see you self assigned it. Do you still want to fix this or do you have any outstanding work on this?

@arvindshmicrosoft arvindshmicrosoft removed their assignment May 19, 2020
@arvindshmicrosoft
Copy link
Member Author

Oh you can totally take it over @keith-turner - I have not been able to spend much time on it. I'm un-assigning myself.

keith-turner added a commit to keith-turner/muchos that referenced this issue May 20, 2020
keith-turner added a commit to keith-turner/muchos that referenced this issue May 20, 2020
Manno15 pushed a commit to Manno15/fluo-muchos that referenced this issue Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants