Update Ansible (Azure) version #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to ansible-core (2.11.3), ansible-lint (5.1.2) * Switch to using community-contributed Azure VMSS Ansible module * Update README to include steps for installing the Azure Ansible modules from Ansible Galaxy * Update CI to align with above
karthick-rn
reviewed
Aug 10, 2021
karthick-rn
approved these changes
Aug 10, 2021
ctubbsii
approved these changes
Aug 10, 2021
|
Thank you @karthick-rn and @ctubbsii. I wonder if @milleruntime or others who have access to an AWS account can do a sanity check with this commit? I am fairly confident that these changes are completely localized to the Azure provisioning code, but if possible it would be great to get a quick sanity run on AWS. |
I don't see anything that could even conceivably apply to AWS. If you want to just merge this, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules from Ansible Galaxy