New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against Fluo 1.2.0 and Accumulo 1.7.3 #146

Merged
merged 6 commits into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@ctubbsii
Member

ctubbsii commented Feb 28, 2018

  • Update build configuration to build against Fluo 1.2.0
  • Change Accumulo default version to 1.7.3, since Fluo 1.2.0 requires 1.7
  • Update copyright date
  • Update Travis config to build with both Accumulo 1.7.3 and 1.8.1
  • Remove unused thrift dependency (version need not be managed
    since Fluo 1.2.0 now shades its version, so it won't conflict with
    Accumulo's version)
Build against Fluo 1.2.0 and Accumulo 1.7.3
* Update build configuration to build against Fluo 1.2.0
* Change Accumulo default version to 1.7.3, since Fluo 1.2.0 requires 1.7
* Update copyright date
* Update Travis config to build with both Accumulo 1.7.3 and 1.8.1
* Remove unused thrift dependency (version need not be managed
  since Fluo 1.2.0 now shades its version, so it won't conflict with
  Accumulo's version)

@ctubbsii ctubbsii self-assigned this Feb 28, 2018

@ctubbsii ctubbsii requested review from mikewalch and keith-turner Feb 28, 2018

.travis.yml Outdated
@@ -14,7 +14,11 @@
language: java
jdk:
- oraclejdk8
script: mvn -U verify javadoc:jar
env:
- EXTRA_OPTS=

This comment has been minimized.

@mikewalch

mikewalch Feb 28, 2018

Member

why set EXTRA_OPTS? Why not just set mvn -U clean verify javadoc:jar -Daccumulo.version=1.8.1?

This comment has been minimized.

@ctubbsii

ctubbsii Feb 28, 2018

Member

This creates a Matrix build in Travis. Travis will run all combinations of env and script. This gives us two builds... one with the default (1.7.3) and one with 1.8.1 explicitly set.

@@ -200,11 +193,6 @@
<artifactId>spark-core_2.10</artifactId>
<version>${spark.version}</version>
</dependency>
<dependency>

This comment has been minimized.

@mikewalch

mikewalch Feb 28, 2018

Member

This is great!

<curator.version>2.7.1</curator.version>
<findbugs.maxRank>13</findbugs.maxRank>
<fluo.version>1.1.0-incubating</fluo.version>

This comment has been minimized.

@keith-turner

keith-turner Feb 28, 2018

Contributor

I would like to take a look at using newer Fluo API in Fluo recipes. But that does not have to be done before releasing recipes.

Attempt to fix Travis CI Matrix builds
Use different variable name for matrix build parameter.
@ctubbsii

This comment has been minimized.

Member

ctubbsii commented Feb 28, 2018

I can't figure out why Travis is failing.

@ctubbsii

This comment has been minimized.

Member

ctubbsii commented Mar 1, 2018

I pushed a bunch of commits trying to fix the Travis builds. Still not sure what's up with Travis... but I'll roll them back / squash them away when I merge. They do not alter the approved PR in any substantive way.

@ctubbsii ctubbsii merged commit 2b13cba into apache:master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ctubbsii ctubbsii deleted the ctubbsii:build-improvements branch Mar 1, 2018

@mikewalch mikewalch added this to the 1.2.0 milestone Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment