added compact transient command #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +123,10 @@ public static void compactTransient(FluoConfiguration fluoConfig) throws Excepti | |||
| TransientRegistry transientRegistry = new TransientRegistry(appConfig); | |||
| List<RowRange> ranges = transientRegistry.getTransientRanges(); | |||
|
|
|||
| Logger logger = LoggerFactory.getLogger(TableOperations.class); | |||
There was a problem hiding this comment.
why not make logger a static field?
There was a problem hiding this comment.
I was thinking it was only used in that method. However I just double checked and another method is logging, so I will make it static.
|
+1 |
keith-turner
force-pushed
the
compact_transient_cmd
branch
from
3e317ff
to
49f5b0d
Compare
keith-turner
added a commit
that referenced
this pull request
Dec 11, 2015
added compact transient command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on apache/fluo#581