Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss get jars behavior #908

Open
keith-turner opened this issue Aug 11, 2017 · 2 comments
Open

Discuss get jars behavior #908

keith-turner opened this issue Aug 11, 2017 · 2 comments

Comments

@keith-turner
Copy link
Contributor

For get jars command add in #907 the command expects the target directory to exist but does not care if the directory is non-empty. I found myself wondering if the behavior should change or if the docs should be improved to clearly state the behavior for a non-empty dir while looking at the PR. I was not sure. Below are some thoughts I had.

  • Should the get jars command create the dir?
  • If the directory is not empty should the get jars command fail? Their are two use cases to consider.
    • A user intentionally adds jars to a dir before calling get jars and does not expect it to empty.
    • A user unintentionally reuses a dir and expects the dir to be empty when its not and ends ups extra/unexpected jars in the dir.
@keith-turner keith-turner added this to the 1.2.0 milestone Aug 11, 2017
@ctubbsii ctubbsii removed this from the 1.2.0 milestone Apr 25, 2018
@GigabyteProductions
Copy link

Could classes be loaded from HDFS directly using Accumulo's VFS classloader?

See: https://blogs.apache.org/accumulo/entry/the_accumulo_classloader

@keith-turner
Copy link
Contributor Author

Could classes be loaded from HDFS directly using Accumulo's VFS classloader?

Yes. One possible way to do this would be to run fluo config -a <app> and grep for the property fluo.observer.jars.url. Its also possible to obtain this property via the Java API using FluoAdmin.getApplicationConfig(). Then the VFS classloader could be configured to use this.

Fluo is not currently using the VFS classloader for itself though. Currently its not doing anything with classloaders and relying on the launch scripts to setup its classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants