Closes #298 - Enable MiniFluo administration from fluo admin script #318
Conversation
|
Should we rework phrasecount and quickstart examples to use this new feature? Thats one way of testing this. If we did that, maybe we could put the work in branch in phrasecount and quickstart repos for now. Leaving master on phrasecount and quickstart based against alpha until beta is released. |
| ``` | ||
| Optionally, check out a stable tag (if you don't want to build a release from master): | ||
| ``` | ||
| git checkout 1.0.0-alpha-1 |
There was a problem hiding this comment.
Could go ahead and put 1.0.0-beta-1 here, as these instructions will not make sense for alpha
|
Should have an IT that exercises |
| </excludes> | ||
| </dependencySet> | ||
| <dependencySet> | ||
| <outputDirectory>lib/log4j</outputDirectory> |
There was a problem hiding this comment.
interesting... maybe we could eventually have a lib/hadoop and lib/accumulo
| log.info("Started MiniAccumulo(accumulo="+cluster.getInstanceName()+" zk="+cluster.getZooKeepers()+")"); | ||
|
|
||
| // configuration that must overridden | ||
| config.setAccumuloInstance(cluster.getInstanceName()); |
There was a problem hiding this comment.
should an exception be thrown if these accumulo props are already set? I am not 100% sure about this. I can think of situation where it would be annoying.... but I can also think of situations where mini fluo does not use the accumulo instance I expected.
There was a problem hiding this comment.
In 03e35f5, We will now throw an exception. An exception is not thrown although if a client property is uncommented but not set (as fluo.properties defaults to this).
|
I created a test that exercises MiniFluo (when it starts its own accumulo) in 1290086 |
|
+1 (would be really nice to make MiniIT use target, but other than that it looks good) |
Closes #298 - Enable MiniFluo administration from fluo admin script
Pull request for #298