GEODE-2891 connect-timeout violation in C++ Native Client #105

gregt5259 · 2017-07-02T10:26:42Z

The fix enables to interpret the time measure unit in handshake as milliseconds rather than seconds.

Change time measure unit for handshake from seconds to milliseconds

jake-at-work

Please rebase your changes on develop rather than merge.

Do not include comments with ticket numbers.
Do not include comments with your name or initials.
Do not leave sources commented out, delete or delete not.

Please follow the C++ style of the community.

I am concerned with the approach of trying to define a pseudo message for handshaking to get a different timeout unit. This may bite us in the future when added new messages to the protocol.

There are a few tickets in flight, or soon to be in flight, that address this problem.

https://issues.apache.org/jira/browse/GEODE-3136
https://issues.apache.org/jira/browse/GEODE-3137

I have begun some experiments with GEODE-3136 and should start committing to it in a few days. All API exposed timeouts will be based on std::chrono::duration so you can clearly see what unit of time your time is and the code behind that API doesn't have to guess. GEODE-3137 will address on use cases internally that aren't addressed when updating the public API. Any configuration files that specify timeout will be updated to take a duration string as well in the format of "1234s", "1234ms", etc.

jake-at-work · 2017-07-02T14:28:37Z

src/cppcache/src/TcrConnection.cpp

@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
  LOGFINE("Attempting handshake with endpoint %s for %s%s connection", endpoint,
          isClientNotification ? (isSecondary ? "secondary " : "primary ") : "",
          isClientNotification ? "subscription" : "client");
-  ConnErrType error = sendData(data, msgLengh, connectTimeout, false);
+  // GT GEODE-2891


Do not include comments with your name or the ticket number.

jake-at-work · 2017-07-02T14:29:06Z

src/cppcache/src/TcrConnection.cpp

@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
  LOGFINE("Attempting handshake with endpoint %s for %s%s connection", endpoint,
          isClientNotification ? (isSecondary ? "secondary " : "primary ") : "",
          isClientNotification ? "subscription" : "client");
-  ConnErrType error = sendData(data, msgLengh, connectTimeout, false);
+  // GT GEODE-2891
+  //ConnErrType error = sendData( data, msgLengh, connectTimeout, false );


Do not leave commented out sources, this is what revision control is for.

jake-at-work · 2017-07-02T14:34:04Z

src/cppcache/src/TcrConnection.cpp

+	    sendTimeoutSec = sendTimeoutSec * 1000;
+	    isPublicApiTimeout = true;
+	    LOGDEBUG("sendData2 %d ", sendTimeoutSec);
+	} 


Formatting does not conform to Google C++ Style Guide.

jake-at-work · 2017-07-02T14:36:21Z

src/cppcache/src/TcrMessage.hpp

@@ -171,7 +173,8 @@ class CPPCACHE_EXPORT TcrMessage {
    GET_DURABLE_CQS_DATA_ERROR = 106,
    GET_ALL_WITH_CALLBACK = 107,
    PUT_ALL_WITH_CALLBACK = 108,
-    REMOVE_ALL = 109
+	REMOVE_ALL = 109,
+	HANDSHAKE = 110


These numbers correspond to protocol message numbers on the server. We can just add one here and expect it not cause issues later.

jake-at-work · 2017-07-02T14:36:35Z

src/cppcache/src/TcrMessage.hpp

@@ -44,6 +44,8 @@
 #include <map>
 #include <vector>

+//


Clean this up.

gregt5259 · 2017-07-03T08:30:46Z

I suggest to fix the issue by defining handshake pseudo message within the range probably defined for such pseudo messages by original design i.e.: typedef enum { /* Server couldn't read message; handle it like a server side exception that needs retries */ HANDSHAKE = -3 NOT_PUBLIC_API_WITH_TIMEOUT = -2, WDYT? Thanks, Dr. Gregory Turovets "…We're all mad here. I'm mad. You're mad." "How do you know I'm mad?" said Alice. "You must be," said the Cat, "or you wouldn't have come here." Alice's Adventures in Wonderland by Lewis Carroll<http://www.livelib.ru/author/157108>. From: Jacob Barrett [mailto:notifications@github.com] Sent: Sunday, July 02, 2017 17:46 To: apache/geode-native <geode-native@noreply.github.com> Cc: Gregory Turovets <gregory.turovets@amdocs.com>; Author <author@noreply.github.com> Subject: Re: [apache/geode-native] GEODE-2891 connect-timeout violation in C++ Native Client (#105) @pivotal-jbarrett requested changes on this pull request. Please rebase your changes on develop rather than merge. Do not include comments with ticket numbers. Do not include comments with your name or initials. Do not leave sources commented out, delete or delete not. Please follow the C++ style of the community. I am concerned with the approach of trying to define a pseudo message for handshaking to get a different timeout unit. This may bite us in the future when added new messages to the protocol. There are a few tickets in flight, or soon to be in flight, that address this problem. https://issues.apache.org/jira/browse/GEODE-3136 https://issues.apache.org/jira/browse/GEODE-3137 I have begun some experiments with GEODE-3136 and should start committing to it in a few days. All API exposed timeouts will be based on std::chrono::duration so you can clearly see what unit of time your time is and the code behind that API doesn't have to guess. GEODE-3137 will address on use cases internally that aren't addressed when updating the public API. Any configuration files that specify timeout will be updated to take a duration string as well in the format of "1234s", "1234ms", etc.

________________________________ In src/cppcache/src/TcrConnection.cpp<#105 (comment)>:

@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(

LOGFINE("Attempting handshake with endpoint %s for %s%s connection", endpoint, isClientNotification ? (isSecondary ? "secondary " : "primary ") : "", isClientNotification ? "subscription" : "client"); - ConnErrType error = sendData(data, msgLengh, connectTimeout, false); + // GT GEODE-2891 Do not include comments with your name or the ticket number.

________________________________ In src/cppcache/src/TcrConnection.cpp<#105 (comment)>:

@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(

LOGFINE("Attempting handshake with endpoint %s for %s%s connection", endpoint, isClientNotification ? (isSecondary ? "secondary " : "primary ") : "", isClientNotification ? "subscription" : "client"); - ConnErrType error = sendData(data, msgLengh, connectTimeout, false); + // GT GEODE-2891 + //ConnErrType error = sendData( data, msgLengh, connectTimeout, false ); Do not leave commented out sources, this is what revision control is for.

________________________________ In src/cppcache/src/TcrConnection.cpp<#105 (comment)>:

- // then app has set timeout in millis, change it to microSeconds

- sendTimeoutSec = sendTimeoutSec * 1000; - isPublicApiTimeout = true; - LOGDEBUG("sendData2 %d ", sendTimeoutSec); - } else { - sendTimeoutSec = sendTimeoutSec * 1000; - } + notPublicApiWithTimeout == TcrMessage::EXECUTE_REGION_FUNCTION_SINGLE_HOP || + // GT GEODE-2891 + notPublicApiWithTimeout == TcrMessage::HANDSHAKE) + { + // then app has set timeout in millis, change it to microSeconds + sendTimeoutSec = sendTimeoutSec * 1000; + isPublicApiTimeout = true; + LOGDEBUG("sendData2 %d ", sendTimeoutSec); + } Formatting does not conform to Google C++ Style Guide<https://google.github.io/styleguide/cppguide.html>.

________________________________ In src/cppcache/src/TcrMessage.hpp<#105 (comment)>:

@@ -171,7 +173,8 @@ class CPPCACHE_EXPORT TcrMessage {

GET_DURABLE_CQS_DATA_ERROR = 106, GET_ALL_WITH_CALLBACK = 107, PUT_ALL_WITH_CALLBACK = 108, - REMOVE_ALL = 109 + REMOVE_ALL = 109, + HANDSHAKE = 110 These numbers correspond to protocol message numbers on the server. We can just add one here and expect it not cause issues later.

________________________________ In src/cppcache/src/TcrMessage.hpp<#105 (comment)>:

@@ -44,6 +44,8 @@

#include <map> #include <vector> +// Clean this up. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#105 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AbZcfm-Wvg_K8tzwTd2ACFihvkB1aQLaks5sJ60jgaJpZM4OLjA1>. This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at https://www.amdocs.com/about/email-disclaimer <https://www.amdocs.com/about/email-disclaimer>

jake-at-work · 2017-07-03T15:15:34Z

I suggest to fix the issue by defining handshake pseudo message within the range probably defined for such pseudo messages by original design i.e.:
typedef enum {
/* Server couldn't read message; handle it like a server side
exception that needs retries */
HANDSHAKE = -3
NOT_PUBLIC_API_WITH_TIMEOUT = -2,

I think that would certainly work better but I think ultimately the fix is to remove the ambiguity between the C++ API and the Server API by strongly typing the duration values as addressed in the mentioned tickets. All duration values can be cast to the internal API supported unit without any ambiguity. After which there is no need to create this pseudo message to change the unit of the ambiguous int value.

jake-at-work · 2017-07-05T14:42:04Z

@gregt5259 please close this pull request since you opened #106.

gregt5259 · 2017-07-07T10:20:23Z

Closed by Ernie Burghardt request as duplicated #106

gregt5259 added 2 commits July 2, 2017 10:27

Merge remote-tracking branch 'refs/remotes/apache/develop' into develop

d4c8401

GEODE-2891: connect-timeout violation in C++ Native Client

c5743fe

Change time measure unit for handshake from seconds to milliseconds

jake-at-work requested changes Jul 2, 2017

View reviewed changes

echobravopapa mentioned this pull request Jul 5, 2017

GEODE-2891 connect-timeout violation in C++ Native Client #106

Closed

gregt5259 closed this Jul 7, 2017

pdxcodemonkey mentioned this pull request Mar 30, 2021

GEODE-8543: Fix for uneccessary connections closure #705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEODE-2891 connect-timeout violation in C++ Native Client #105

GEODE-2891 connect-timeout violation in C++ Native Client #105

gregt5259 commented Jul 2, 2017 •

edited

jake-at-work left a comment

jake-at-work Jul 2, 2017

jake-at-work Jul 2, 2017

jake-at-work Jul 2, 2017

jake-at-work Jul 2, 2017

jake-at-work Jul 2, 2017

gregt5259 commented Jul 3, 2017 via email

jake-at-work commented Jul 3, 2017

jake-at-work commented Jul 5, 2017

gregt5259 commented Jul 7, 2017

GEODE-2891 connect-timeout violation in C++ Native Client #105

GEODE-2891 connect-timeout violation in C++ Native Client #105

Conversation

gregt5259 commented Jul 2, 2017 • edited

jake-at-work left a comment

Choose a reason for hiding this comment

jake-at-work Jul 2, 2017

Choose a reason for hiding this comment

jake-at-work Jul 2, 2017

Choose a reason for hiding this comment

jake-at-work Jul 2, 2017

Choose a reason for hiding this comment

jake-at-work Jul 2, 2017

Choose a reason for hiding this comment

jake-at-work Jul 2, 2017

Choose a reason for hiding this comment

gregt5259 commented Jul 3, 2017 via email

jake-at-work commented Jul 3, 2017

jake-at-work commented Jul 5, 2017

gregt5259 commented Jul 7, 2017

gregt5259 commented Jul 2, 2017 •

edited