GEODE-4427: Moving CliCallbackMethod to DistributedSystemImpl #233
Conversation
There was a problem hiding this comment.
Windows won't build
C:\nativeclient\clicache\src\DistributedSystem.cpp(498): error C2440: 'type cast': cannot convert from 'void *' to 'apache::geode::client::CliCallbackMethod' [C:\build\clicache\src\Apache.Geode.vcxproj]
C:\nativeclient\clicache\src\DistributedSystem.cpp(498): note: No constructor could
Signed-off-by: Blake Bender <bbender@pivotal.io>
|
Fixed the build issue, needed some changes in the c++/cli. |
| @@ -493,7 +493,7 @@ namespace Apache | |||
| &CliCallbackDelegate::Callback); | |||
|
|
|||
| native::DistributedSystemImpl::registerCliCallback(System::Threading::Thread::GetDomainID(), | |||
| (native::CliCallbackMethod)System::Runtime::InteropServices:: | |||
| (void (*)(apache::geode::client::Cache &cache))System::Runtime::InteropServices:: | |||
There was a problem hiding this comment.
Given that you remove a C-style function pointer on C++ side (which I think is appropriate), is there any reason to perpetuate the C-style function pointer here? If you must, then why not use a C++ style cast? Furthermore, is it possible to replace CliCallbackDelegate and cliCallback with some std::functional magic now that that's what will be used in the C++ side?
There was a problem hiding this comment.
The cast is required because the delegate function pointer given by this call is a void*. It won’t convert to anything that matches std::function will accept.
There was a problem hiding this comment.
Do we need to use delegates? Was that required because of appdomain fun? If so, is it still relevant in a world without globals?
There was a problem hiding this comment.
Sadly we still need this delegate to call back from the native side into the .NET side for cleanup when the cachenis closed. It could probably be refactored but its outside this scope.
…#233) Signed-off-by: Blake Bender <bbender@pivotal.io>
No description provided.