GEODE-5847: Integrate clang-format into CMake. #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-at-work
force-pushed
the
wip/clang-format
branch
from
28f9752
to
dd0134e
Compare
echobravopapa
requested changes
Oct 11, 2018
There was a problem hiding this comment.
PR #374 is merged you can resolve and re-trigger Travis on this PR
jake-at-work
force-pushed
the
wip/clang-format
branch
2 times, most recently
from
0d3413a
to
4c458be
Compare
|
This looks awesome! I assume this corrects any IDE formatting issues so that as long as I compile before I check-in, they will be corrected. |
|
If clang-format is found, yes. |
* Formats all C++ sources on compile if they have changed.
jake-at-work
force-pushed
the
wip/clang-format
branch
2 times, most recently
from
83c0c8a
to
5563822
Compare
* Will exit non-zero if formatting changes while building.
Ignoring clang-analyzer-cplusplus.NewDeleteLeaks in old integration tests because there is a fundamental flaw in the design the relies on the leaking of memory. Because it uses MACROS to define the tasks we also can't just ignore the offending lines.
jake-at-work
force-pushed
the
wip/clang-format
branch
from
a300290
to
23b9516
Compare
echobravopapa
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #374