GEODE-8053: Fixes lingering StatsManager after Cache close. #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this was likely not a problem in C++ it was a big problem in .NET due to the reliance on GC to destruct native objects. The StatsManager didn't stop until it was destructed. This in turn stops the HostStatSampler. In .NET this leaves the stats system trying to run on a closed but not destructed Cache instance.
pdxcodemonkey
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this was likely not a problem in C++ it was a big problem in .NET due to
the reliance on GC to destruct native objects. The StatsManager didn't stop
until it was destructed. This in turn stops the HostStatSampler. In .NET this
leaves the stats system trying to run on a closed but not destructed Cache
instance.