GEODE-8183: Update dockerfile versions #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Geode from 1.9 to 1.12 - CMake from 3.12.2 to 3.12.4 - Set to noninteractive so that building doesn't require interaction - Make key=value for LABEL clearer
jake-at-work
approved these changes
May 28, 2020
There was a problem hiding this comment.
It would be nice to fix this to use the images coming out of geode. I think there is a docker hub apache/geode:latest. We could copy geode from that image into this image rather than extracting and downloading. Heck might even be able to just layer on the clang bits to the geode base. I can't recall what its base OS is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure how the Travis dockerfile has stayed up to date. I'm assuming it is part of the release process to update it, but changes never get ported here since this was trying to install 1.9 which you can't download anymore.