GEODE-8457: Fix crash when IO_error and single-hop=false #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moleske
reviewed
Aug 26, 2020
cppcache/src/ThinClientPoolDM.cpp
Outdated
| LOGINFO("Removing bucketServerLocation %s due to GF_IOERR", | ||
| sl->toString().c_str()); | ||
| m_clientMetadataService->removeBucketServerLocation(sl); | ||
| if (m_clientMetadataService != nullptr) { |
There was a problem hiding this comment.
When I see an if statement, I usually think there's a possible test case. One for when the statement is true, and one for false. Is it possible to write a test for this and the below if statements?
There was a problem hiding this comment.
The m_clientMetadataService member variable is null when single-hop is not enabled.
I have duplicated the test cases I created to verify the fix for GEODE-8231 which had single-hop enabled, to also test the case when single-hop is disabled.
jake-at-work
approved these changes
Aug 26, 2020
cppcache/src/ThinClientPoolDM.cpp
Outdated
| LOGINFO("Removing bucketServerLocation %s due to GF_IOERR", | ||
| sl->toString().c_str()); | ||
| m_clientMetadataService->removeBucketServerLocation(sl); | ||
| if (m_clientMetadataService != nullptr) { |
There was a problem hiding this comment.
The one style thing I would point out is that std::unique_ptr explicitly converts to true if set or false if is nullptr specifically for the usage in if statements like this.
if (m_clientMetadataService) {
m_clientMetadataService->doSomething();
}
alb3rtobr
approved these changes
Aug 27, 2020
alb3rtobr
pushed a commit
to Nordix/geode-native
that referenced
this pull request
Aug 27, 2020
- Added 2 test cases and style changes after review
jvarenina
pushed a commit
to Nordix/geode-native
that referenced
this pull request
Oct 28, 2020
- Added 2 test cases and style changes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.