Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-8449: Cleanup containers before each test #649

Merged
merged 2 commits into from Sep 10, 2020
Merged

GEODE-8449: Cleanup containers before each test #649

merged 2 commits into from Sep 10, 2020

Conversation

mmartell
Copy link
Contributor

@mmartell mmartell commented Sep 9, 2020

This cleans up any docker containers at the beginning of each test in case of a test failure that leaves docker containers up.

@mmartell
Cleanup containers before each test
c12c9f1 
- in case a test fails to cleanup
echobravopapa
echobravopapa requested changes Sep 9, 2020
View reviewed changes
Copy link

@echobravopapa echobravopapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve on the functionality, just need to see a strong case for the approach noted in the review...

clicache/acceptance-test/SNITests.cs Outdated Show resolved Hide resolved
cppcache/acceptance-test/SNITest.cpp Show resolved Hide resolved
@mmartell mmartell merged commit e6ffd8e into apache:develop Sep 10, 2020
@mmartell mmartell deleted the GEODE-8449-docker-cleanup branch November 17, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdxcodemonkey pdxcodemonkey pdxcodemonkey left review comments

@echobravopapa echobravopapa echobravopapa approved these changes

@moleske moleske Awaiting requested review from moleske

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mmartell @pdxcodemonkey @moleske @echobravopapa