New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-8530: Fix for coredump during tx commit #656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there.
- added missing new line - replaced std::string with const auto - formatting corrected
pdxcodemonkey
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and the new test passes on all platforms. thanks for the fix!
pdxcodemonkey
pushed a commit
to moleske/geode-native
that referenced
this pull request
Sep 25, 2020
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there. * Minor fixes introduced: - added missing new line - replaced std::string with const auto - formatting corrected
Thanks for the review! |
jvarenina
added a commit
to Nordix/geode-native
that referenced
this pull request
Sep 28, 2020
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there. * Minor fixes introduced: - added missing new line - replaced std::string with const auto - formatting corrected
jvarenina
added a commit
to Nordix/geode-native
that referenced
this pull request
Oct 15, 2020
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there. * Minor fixes introduced: - added missing new line - replaced std::string with const auto - formatting corrected
jvarenina
added a commit
to Nordix/geode-native
that referenced
this pull request
Oct 28, 2020
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there. * Minor fixes introduced: - added missing new line - replaced std::string with const auto - formatting corrected
jvarenina
added a commit
to Nordix/geode-native
that referenced
this pull request
Oct 28, 2020
Client is fixed in a way that ignores all regions enlisted within transaction that client doesn't have configured. This behavior is aligned with the java client, since same thing is done there. * Minor fixes introduced: - added missing new line - replaced std::string with const auto - formatting corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.