Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-8530: Fix for coredump during tx commit #656

Merged
merged 2 commits into from Sep 25, 2020

Conversation

jvarenina
Copy link
Contributor

Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.
- added missing new line
- replaced std::string with const auto
- formatting corrected
Copy link
Contributor

@pdxcodemonkey pdxcodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the new test passes on all platforms. thanks for the fix!

@pdxcodemonkey pdxcodemonkey merged commit de473c3 into apache:develop Sep 25, 2020
pdxcodemonkey pushed a commit to moleske/geode-native that referenced this pull request Sep 25, 2020
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

* Minor fixes introduced:

- added missing new line
- replaced std::string with const auto
- formatting corrected
@jvarenina
Copy link
Contributor Author

Thanks for the review!

@jvarenina jvarenina deleted the feature/GEODE-8530 branch September 28, 2020 06:32
jvarenina added a commit to Nordix/geode-native that referenced this pull request Sep 28, 2020
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

* Minor fixes introduced:

- added missing new line
- replaced std::string with const auto
- formatting corrected
jvarenina added a commit to Nordix/geode-native that referenced this pull request Oct 15, 2020
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

* Minor fixes introduced:

- added missing new line
- replaced std::string with const auto
- formatting corrected
jvarenina added a commit to Nordix/geode-native that referenced this pull request Oct 28, 2020
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

* Minor fixes introduced:

- added missing new line
- replaced std::string with const auto
- formatting corrected
jvarenina added a commit to Nordix/geode-native that referenced this pull request Oct 28, 2020
Client is fixed in a way that ignores all regions enlisted within
transaction that client doesn't have configured. This behavior is
aligned with the java client, since same thing is done there.

* Minor fixes introduced:

- added missing new line
- replaced std::string with const auto
- formatting corrected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants