Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-8925: port singleHop tests to new framework #760

Merged
merged 11 commits into from Mar 27, 2021
Merged

GEODE-8925: port singleHop tests to new framework #760

merged 11 commits into from Mar 27, 2021

Conversation

mmartell
Copy link
Contributor

@mmartell mmartell commented Mar 8, 2021

Captures the following flaky tests into the new PartitionedRegionOps test:

  • testThinClientPRSingleHop
  • testThinClientPutAllPRSingleHop

echobravopapa
echobravopapa requested changes Mar 9, 2021
View reviewed changes
Copy link

@echobravopapa echobravopapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small suggestions...

cppcache/src/TcrMessage.cpp Show resolved Hide resolved
cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
jake-at-work
jake-at-work requested changes Mar 10, 2021
View reviewed changes
cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
cppcache/src/TcrMessage.cpp Outdated Show resolved Hide resolved
pdxcodemonkey
pdxcodemonkey requested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@pdxcodemonkey pdxcodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small tweaks to variable declarations. More generically, though, if this is a port of an existing test to the new framework, where are the changes to delete the test(s) from the old framework?

cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
cppcache/integration/test/PartitionRegionOpsTest.cpp Outdated Show resolved Hide resolved
pdxcodemonkey
pdxcodemonkey requested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@pdxcodemonkey pdxcodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see the old test code going away in this PR. Please delete the tests you're replacing.

@mmartell mmartell force-pushed the GEODE-8925-port-testThinClientPRSingleHop branch from b04afe1 to 587a7ba Compare March 26, 2021 04:48
@mmartell
Copy link
Contributor Author

The two ported tests (testThinClientPRSingleHop and testThinClientPutAllPRSingleHop) have been removed.

@pdxcodemonkey
Copy link
Contributor

@mmartell Looks like this one is good to go, but you'll need to rebase onto develop to resolve merge conflicts.

@mmartell mmartell force-pushed the GEODE-8925-port-testThinClientPRSingleHop branch from 587a7ba to 3dda2f5 Compare March 27, 2021 02:06
@mmartell mmartell merged commit 7e3a013 into apache:develop Mar 27, 2021
@mmartell mmartell deleted the GEODE-8925-port-testThinClientPRSingleHop branch November 17, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdxcodemonkey pdxcodemonkey pdxcodemonkey approved these changes

@jake-at-work jake-at-work jake-at-work approved these changes

@echobravopapa echobravopapa echobravopapa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mmartell @pdxcodemonkey @jake-at-work @echobravopapa