Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-9334: Update UG generation scripts #816

Merged
merged 1 commit into from Jun 10, 2021

Conversation

alb3rtobr
Copy link
Contributor

This PR aligns the user guide generation instructions and scripts with the instructions recently added in Geode (see GEODE-9042).

Uplifts Bookbinder and other gems version, and simplifies the Docker-based scripts to preview the user guides.

Copy link
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo!

@alb3rtobr
Copy link
Contributor Author

CI fails but not due to this PR content.
Clang-format failing saying I should format a file I have not modified. And the "build-windows-2016-vs-2017-debug" failed due to the worker machine has not "tar" installed 😮.

@pdxcodemonkey
Copy link
Contributor

I'm attempting to address CI issues - today is day 2 :/. PR #819 has the formatting fix in it - we updated the version of clang-format to 12 the other day because that's the new default for homebrew on MacOS, and now we have one file already checked into develop that it doesn't like. LGTM is also failing right now because of errors downloading ACE. Please stand by, we'll get it sorted ASAP.

@alb3rtobr
Copy link
Contributor Author

thanks for the info @pdxcodemonkey . BTW I saw the clang uplift so I installed clang 12. If I run cmake --build . --target all-clangformat there are two files that are modified, but RegionAttributes.cpp is not one of them:

cppcache/include/geode/CacheableString.hpp
cppcache/integration/framework/Cluster.cpp

@pdxcodemonkey
Copy link
Contributor

Still working on that, as well. We're slowly coming to the conclusion that not only is clang-format subtly incompatible between versions, it is also sometimes subtly incompatible in the same version between platforms, most notably Windows. In this case, however, I think we've accidentally picked up a daily build version or something, because if you run the CI Docker image it reports this:

root@87ac1e844af6:/# clang-format --version
Ubuntu clang-format version 12.0.1-++20210525082622+328a6ec95532-1~exp1~20210525063352.95

Again, we're working on it. Multiple fires to put out right now :)

@pdxcodemonkey
Copy link
Contributor

@alb3rtobr please rebase onto latest develop to fix `clang-format, then this will pass gates and can be merged.

@alb3rtobr
Copy link
Contributor Author

@alb3rtobr please rebase onto latest develop to fix `clang-format, then this will pass gates and can be merged.

done, thanks!

@pdxcodemonkey pdxcodemonkey merged commit 9d4ff01 into apache:develop Jun 10, 2021
davebarnes97 pushed a commit to davebarnes97/geode-native that referenced this pull request Feb 9, 2022
davebarnes97 pushed a commit to davebarnes97/geode-native that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants